Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHF fixes #1285

Merged
merged 7 commits into from
Oct 14, 2024
Merged

SHF fixes #1285

merged 7 commits into from
Oct 14, 2024

Conversation

OlivierBBB
Copy link
Collaborator

@OlivierBBB OlivierBBB commented Sep 23, 2024 •
edited
Loading

  • SHB_k_HI/LO went from 16B to 1B tracing
  • debugging range
  • resultChecking fails for
  /** this range fails if you use the default resultChecking == true */
  @Test
  void issue1280_range_4065365_4065369() {
    replay(LINEA_MAINNET, "4065365-4065369.json.gz", false);
  }

@OlivierBBB OlivierBBB linked an issue Sep 23, 2024 that may be closed by this pull request
Failing ranges for SHF module #1280
Closed
@OlivierBBB OlivierBBB changed the title fix: SHF fixes Sep 23, 2024
@OlivierBBB OlivierBBB marked this pull request as ready for review September 24, 2024 14:17
@DavePearce
Copy link
Collaborator

The result checking is failing because of the issues addressed in #1291. This is the key error:

TRACE - Contract creation error: account has already been created for address 0xfce10048e89baa0bfab8757ab45e2d057bb917ee

DavePearce
DavePearce approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@DavePearce DavePearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (though keeping in mind I don't follow everything going on here)

@OlivierBBB OlivierBBB merged commit 9dd5f55 into arith-dev Oct 14, 2024
5 checks passed
@OlivierBBB OlivierBBB deleted the 1280-failing-ranges-for-shf-module branch October 14, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavePearce DavePearce DavePearce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing ranges for SHF module
2 participants
@OlivierBBB @DavePearce